Change Monero privacy label from 'No Privacy' to 'IP is visible'#5965
Change Monero privacy label from 'No Privacy' to 'IP is visible'#5965
Conversation
|
Needs screenshot. Also it looks like the "Network Privacy" and "Monero Server" headers are violating 1rem required margins on the left. |
|
|
So the agent couldn't find any documentation about the 1rem rule perhaps because we haven't solidified it into documentation somewhere. Do you have a prompt for your agents to follow this rule that you mention? If so please do share, if not, then no worries. |
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
@samholmes good callout on the 1rem rule. Could you create a follow-up Asana task to flush out/document the rule details and assign it to Jon? |
samholmes
force-pushed
the
sam/fix-nym-privacy-copy
branch
from
088c0fa to
527fa85
Compare
Add SceneContainer wrapper for 1rem margin convention (0.5rem container padding + 0.5rem element margin). Add section headers for token detection and asset settings. Use refresh icon instead of navigation chevron for the detect tokens action to indicate it performs an action rather than navigating to a new scene.
Wrap settings sections in EdgeCard components with section dividers for consistent design with AssetSettingsScene. Apply SceneContainer for proper 1rem margin convention. Update MaybePrivateNetworkingSetting, MaybeCustomServersSetting, and MaybeMoneroUserSettings to use EdgeCard sections wrapper.
samholmes
force-pushed
the
sam/fix-nym-privacy-copy
branch
from
527fa85 to
31c66f7
Compare
4 participants
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Low Risk
Primarily UI/layout refactors and a string copy update; minimal functional impact aside from potential visual/regression issues in settings screens.
Overview
Updates settings UI layouts to the newer card-based styling:
AssetSettingsScenenow usesSceneContainer+EdgeCardwithSettingsRowfor “Detect tokens”, andCurrencySettingsScene/networking settings (MaybeCustomServersSetting,MaybeMoneroUserSettings,MaybePrivateNetworkingSetting) wrap their rows insideEdgeCardsections.Changes the Network Privacy “Standard” label from “No Privacy” to “IP is visible” (enUS), and updates the
CurrencySettingssnapshot to match the new rendering structure. Also removesAssetSettingsScene.tsxfrom the ESLint “warn-only TypeScript errors” file allowlist.Written by Cursor Bugbot for commit 31c66f7. This will update automatically on new commits. Configure here.